Skip to content

Update deprecated selenium logs method in E2E tests

Jay McCure requested to merge jmc-fix-e2e-browser-logs into master

What does this MR do and why?

Resolves #383809 (closed)

Manager#logs is removed upstream (https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES#L64) so every time we interrogate the browser logs we are getting an error. e.g. https://gitlab.com/gitlab-org/gitlab/-/jobs/3384875700#L181

This MR updates the E2E tests to use Browser#logs

Screenshots or screen recordings

Example of failure here: https://gitlab.com/gitlab-org/gitlab/-/jobs/3384875700#L181

Before: Screen_Shot_2022-11-28_at_11.30.59

After: Error logged is the actual browser error as expected: Screen_Shot_2022-11-28_at_11.33.17

How to set up and validate locally

Run any E2E test, during the test change the URL to something that doesn't exist (e.g. an MR with an ID that doesn't exist) forcing a 404 error page. Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports

Loading