Skip to content

Update spec for filter item

Samantha Ming requested to merge update-spec-for-shared-filter-item into master

What does this MR do and why?

This MR is a response to this comment:

!105125 (comment 1189335038)

This is a good example why we should use toStrictEqual() sparingly and favor .toMatchObject() instead. It's not great to break unrelated tests simply because we added some non-required props with default values to a shared component.

Screenshots or screen recordings

There is no UI/UX changes to this MR

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Samantha Ming

Merge request reports

Loading