Skip to content

Only retry on network error on suggested reviewers

Tan Le requested to merge 381795-ignore-suggested-reviewers-internal-server-error into master

What does this MR do and why?

We would like to track only network errors when calling the suggested reviewers' client. These types of errors will deplete the error budget.

Other application errors that are deep in the stack and not network-related are not retriable but will be tracked and reported internally in the suggested reviewers monitoring infrastructure.

For reference, this is the list of all GRPC status codes.

The user-facing feature is gated behind a feature flag suggested_reviewers_control that is disabled by default to no change log is required.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #381795

Edited by Tan Le

Merge request reports