Skip to content

Fix page class logging when clicking in E2E tests

Jay McCure requested to merge jmc-fix-page-class-logging-e2e-tests into master

What does this MR do and why?

In the E2E tests there is logging for when we click on a button. When we pass in an expected page/modal/section class currently the logging just prints out Class for example:

[Dec 05 2022 02:23:42 UTC (QA Tests)] INFO -- clicking :issuable_create_button , expecting to be at Class

https://gitlab.com/gitlab-org/gitlab/-/jobs/3420770136#L282

This MR fixes this log statement to print the class name and adds a test.

Screenshots or screen recordings

Before: [Dec 02 2022 16:55:10 AEST (QA Tests)] INFO -- clicking :revert_button , expecting to be at Class

After: [Dec 02 2022 16:55:10 AEST (QA Tests)] INFO -- clicking :revert_button and ensuring QA::Page::Component::CommitModal is present

How to set up and validate locally

  • Run any test that uses click_element AND passes in a page class. e.g. Create Merge request push options sets title and description
  • View logs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports