Skip to content

Refactor and test reset_merge_request_approvals

Bogdan Denkovych requested to merge refactor-reset_merge_request_approvals into master

What does this MR do and why?

This MR

  • Changes the definition of conditions in app/policies/base_policy.rb for consistency with others. It doesn't change its behavior.
  • Adds tests for reset_merge_request_approvals ability.
  • Moves tests "PUT :id/merge_requests/:merge_request_iid/reset_approvals" from spec/requests/api/merge_requests_spec.rb to spec/requests/api/merge_request_approvals_spec.rb and improves them.

Related to !95525 (merged), !104496 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bogdan Denkovych

Merge request reports

Loading