Skip to content

Add bulk_import_enabled to application_settings db table

George Koltsov requested to merge georgekoltsov/add-bulk-import-application-setting into master

What does this MR do and why?

This MR adds a new bulk_import_enabled column to application_settings db table. Defaults to false.

It's currently not used anywhere and will be used in a follow up MRs. Main usacase is to provide an ability for admins of self-managed instances to enabled/disable GitLab Migration (also known as Bulk Imports) functionality.

Once this setting is merged we need to (in future MRs):

  1. First, enable it on .com to avoid any feature downtime (since bulk_import feature flag is rolled out on .com).
  2. Update API/controller actions to respect this setting
  3. Update documentation to mention newly added setting
Migration output https://gitlab.com/gitlab-org/gitlab/-/jobs/3441896494 
main: == 20221207140259 AddBulkImportEnabledToApplicationSettings: migrating ========
main: -- add_column(:application_settings, :bulk_import_enabled, :boolean, {:default=>false, :null=>false})
main:    -> 0.0024s
main: == 20221207140259 AddBulkImportEnabledToApplicationSettings: migrated (0.0066s) 

ci: == 20221207140259 AddBulkImportEnabledToApplicationSettings: migrating ========
ci: -- add_column(:application_settings, :bulk_import_enabled, :boolean, {:default=>false, :null=>false})
ci:    -> 0.0027s
ci: == 20221207140259 AddBulkImportEnabledToApplicationSettings: migrated (0.0073s)

image

Mentions #383268 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by George Koltsov

Merge request reports