Skip to content

Clean up image filter and cluster filter isLoading and error message

Daniel Tian requested to merge 385158-clean-up-image-cluster-filter-properties into master

What does this MR do and why?

For the image filter and cluster filter on the vulnerability report, this MR does the following:

  1. Renames the isLoading property to loading to avoid confusion. It's not a boolean, it's a loading key used by Apollo that's incremented when a query is loading and decremented when the request is done.

  2. Moves the error messages for both filters from constants.js into its $options.i18n. This keeps the error message inside the component rather than reaching out into a separate file.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #385158 (closed)

Merge request reports