Skip to content

Set Group ID when fabricate by browser

Will Meek requested to merge qa_group_id_fix into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Tests were failing to fabricate Projects via API in the current FIPS nightly. This is because Group was being fabricated via Browser UI (for smoke tests), but the ID was not being set.

This MR sets the ID when Group is fabricated by browser such that Projects can be fabricated via API.

Note that this is a stepping stone between Smoke tests having been made FIPS mode compatible, and a greater number of a subset of our test suite being FIPS mode compatible (ie. don't fabricate via API at all).

The current FIPS nightly full suite runs in non-EE mode to allow for access tokens / API fabrication where available.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Run an affected test in FIPS mode

FIPS=1 CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/3_create/repository/clone_spec.rb:31

Test should successfully fabricate project.

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports