Skip to content

Add false positive alert to finding modal

Daniel Tian requested to merge 382204-add-false-positive-alert-to-finding-modal into master

What does this MR do and why?

This MR adds the false positive alert to the finding modal:
ksnip_20221208-105442

Describe in detail what your merge request does and why.

How to set up and validate locally

  1. Clone the security-reports project, it has been updated with a vulnerability that's a false positive: https://gitlab.com/gitlab-examples/security/security-reports
  2. Run a pipeline, then go to the pipeline details and click on the security tab.
  3. Filter by Secret Detection results. Find the finding with the name "Twitch API token detected; please remove and revoke it if this is a leak.".
  4. Click on it to show the modal. You should see the "false positive detected" card at the top.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382204 (closed)

Edited by Daniel Tian

Merge request reports