Skip to content

Remove the `container_registry_delete_repository_with_cron_worker` FF

David Fernandez requested to merge 378818-feature-flag-cleanup into master

🏎 Context

Deleting a container repository is a quite complex operation. As such, it's handled by a background job. See !101946 (merged) for way more details.

The current background job present several reliability issues as listed in #217702 (closed).

We decided to switched the background job implementation to a limited capacity one since it can cope with issues, hiccups easily.

This switch was gated by a feature flag. Rollout issue: #378818 (closed).

The new background job has been running for 2 days with no issues. In addition, we observed situations where the new background job properly handled an execution timeout (it simply stopped the ongoing delete and resumed at a later time).

Since the switch is a success, time to remove the feature flag. It is this MR.

🤔 What does this MR do and why?

  • Remove the container_registry_delete_repository_with_cron_worker feature flag.
  • Update all related code and specs.
  • Prepare app/workers/delete_container_repository_worker.rb (old worker class) for its removal.

📺 Screenshots or screen recordings

None

⚗ How to set up and validate locally

See !101946 (merged)

🚥 MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Fernandez

Merge request reports