Skip to content

Add resolved Indicator to CodeQuality MR Widget

What does this MR do and why?

This MR is meant to solve: #374631 (closed)

It adds an indicator Label to the resolved Issues listed in the CodeQuality Merge Request Widget.

Screenshots or screen recordings

before after
Screenshot_2022-12-09_at_15.15.51 Screenshot_2022-12-11_at_21.27.54

How to set up and validate locally

  1. clone this Project https://gitlab.com/jannik_lehmann/code-quality-test
  2. recreate this MR jannik_lehmann/code-quality-test!4 & run a pipeline to trigger the widget
  3. apply this patch
diff --git a/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js b/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js
index fd28df2fa38d..cf19a91eb113 100644
--- a/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js
+++ b/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js
@@ -77,6 +77,46 @@ export default {
     fetchFullData() {
       const fullData = [];

+      this.collapsedData = {
+        resolvedErrors: [
+          {
+            name: 'Method `noise` has 9 arguments (exceeds 4 allowed). Consider refactoring.',
+            path: 'noise.rb',
+            urlPath:
+              '/root/code-quality-test-index/-/blob/5ef79e9360b044ce98def6d0abd2e34b8dd39773/noise.rb#L2',
+            description:
+              'Method `noise` has 9 arguments (exceeds 4 allowed). Consider refactoring.',
+            severity: 'major',
+            file_path: 'noise.rb',
+            line: 2,
+            web_url:
+              'http://gdk.test:3000/root/code-quality-test-index/-/blob/5ef79e9360b044ce98def6d0abd2e34b8dd39773/noise.rb#L2',
+          },
+        ],
+        newErrors: [
+          {
+            name:
+              'Method `more_noise_hi` has 9 arguments (exceeds 4 allowed). Consider refactoring.',
+            path: 'noise.rb',
+            urlPath:
+              '/root/code-quality-test-index/-/blob/5ef79e9360b044ce98def6d0abd2e34b8dd39773/noise.rb#L7',
+            description:
+              'Method `more_noise_hi` has 9 arguments (exceeds 4 allowed). Consider refactoring.',
+            severity: 'major',
+            file_path: 'noise.rb',
+            line: 7,
+            web_url:
+              'http://gdk.test:3000/root/code-quality-test-index/-/blob/5ef79e9360b044ce98def6d0abd2e34b8dd39773/noise.rb#L7',
+          },
+        ],
+        existingErrors: [],
+        errorSummary: {
+          total: 2,
+          resolved: 1,
+          errored: 1,
+        },
+      };
+
       this.collapsedData.newErrors.map((e) => {
         return fullData.push({
           text: `${capitalizeFirstCharacter(e.severity)} - ${e.description}`,

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading