Draft: Don't explicitly `cd` into `TF_ROOT`
What does this MR do and why?
This MR removes the explicit cd "${TF_ROOT}"
from most of the jobs which don't require it anymore, because
of the -chdir "${TF_ROOT}"
we do in the gitlab-terraform
script.
There is a few things to consider here:
-
Base
needs to be compatible withv0.43.0
ofgitlab-terraform
, which already supports-chdir
- Before terraform-images!162 (merged)
plan.json
wouldn't be stored withinTF_ROOT
if there wasn't acd
- once terraform-images!162 (merged) this MR can be merged, too - with (2) the
Base.latest
doesn't require any explicitcd
s at all - even with (2) the
Base
still requires acd
for thebuild
job so that it correctly stores theplan.json
withinTF_ROOT
-
TF_PLAN_CACHE
other thanTF_ROOT/plan.cache
andTF_PLAN_JSON
other thanTF_ROOT/plan.json
are NOT supported (see terraform-images!162 (comment 1205342947)) before this MR and after this MR. Let's handle it outside of this.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.