Skip to content

Fix Mardown Drawer top position meansurement trigger

Tomas Bulva requested to merge fix-mardown-drawer-compute-top into master

What does this MR do and why?

When the Markdown drawer renders it requires the top position to determent where to render. I originally had this to be measured when the template is rendered but it was causing race conditions as performance bar content renderers are too slow sometimes. I moved the measuring action to happen on the open drawer.

Screenshots or screen recordings

before after
Screenshot_2022-12-12_at_15.41.43 Screenshot_2022-12-12_at_15.41.49

How to set up and validate locally

  1. Checkout this branch

  2. navigate to the advanced search page: http://your.gdk:3000/search

  3. If you don't have advancer search enabled do so. (step by step)

  4. make sure you have FF enabled (run Feature.enable(:search_page_vertical_nav) in rails console)

  5. In a case you don't see Syntax options button on the search page apply the syntax-options.patch

  6. after the page loads verify that the syntax options drawer loads properly without performance bar

  7. verify that the page loads with the performance bar enabled

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #329234 (closed)

Edited by Nataliia Radina

Merge request reports