Skip to content

Don't start SidekiqMemoryKiller if watchdog is enabled

Nikola Milojevic requested to merge replace_sidekiq_memory_killer_with_the_watchdog into master

What does this MR do and why?

This MR prevents Sidekiq Memory Killer from starting if Watchdog is enabled

It will not affect production, since Watchdog is disabled by default for Sidekiq. Once we enable Watchdog for sidekiq, it will replace Sidekiq MemoryKiller with backward-compatible monitors which will keep the same behavior.

It also stops watchdog execution if no monitors are configured. We have soft and hard limits configured only for cathcall shard and urgent-bound-shard. For other shards we are not running SidekiqMemoryKiller. We want to keep the same behavior for the Watchdog.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to: #385427 (closed)

Edited by Nikola Milojevic

Merge request reports