Skip to content

Add custom cop for feature flag checks

Sylvester Chin requested to merge sc1-feature-flag-cop into master

What does this MR do and why?

This MR adds a cop to prevent checking feature flags in instrumentation, monkey-patches and Redis folders. These are the 3 folders where modules are used in monkey-patches (instrumentation/patch) or where Redis could loopback and call itself. The purpose is to avoid cyclical dependencies from forming (gem code calling GitLab code) and unending recursive loops.

Issue: #385237

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports