Skip to content

Remove gl-card related styles

Eduardo Sanz García requested to merge eduardosanz/remove-card-classes into master

What does this MR do and why?

app/views/layouts/terms.html.haml defines the general card layout with its header and body.

A portion of the body is rendered by app/views/users/terms/index.html.haml which render a Vue component that uses a gl-card-body (again) and gl-card-footer (wrong). gl-card-footer should only be used on elements outside the body.

Closes #366880 (closed)

Changelog: changed

Screenshots or screen recordings

Before

image

After

image

How to set up and validate locally

  1. In the Admin area > Settings > General > Terms and conditions, add your terms: https://gdk.test:3443/admin/application_settings/general#js-terms-settings
  2. Select All users must accept the Terms of Service and Privacy Policy to access GitLab checkbox
  3. Select Save changes
  4. Go to: https://gdk.test:3443/-/users/terms

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports