Move OnCall Schedules timezone to the shared Timezone Dropdown
requested to merge 378631-move-oncall-schedules-timezone-picker-to-the-shared-timezone-dropdown into master
What does this MR do and why?
- Migrates custom GlDropdown in creating oncall schedule modal, to a shared TimezoneDropdown. There is a slight difference in formatting (
[]
instead of()
for UTM) - I decided to keep it as is for consistency across application (see CI/CD > Schedules > New Schedule for reference). - Adds a dropdownClass property to customise shared dropdown. In case of oncall form, extra margin did not allow to display validation message directly under the box. Hence the addition and reset to 0px.
- Adds a unit test to TimezoneDropdown for marking selected timezone.
Screenshots or screen recordings
before | after |
---|---|
How to set up and validate locally
Prerequisite:
- This is a premium feature
- You must have at least the Maintainer role.
To open create an on-call schedule modal:
- On the top bar, select Main menu > Projects and find your project.
- On the left sidebar, select Monitor > On-call Schedules.
- Select Add a schedule.
- Enter the schedule’s name and description and select a time zone.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #378631 (closed)
Edited by Paulina Sedlak-Jakubowska