Remove a conditional that can never trigger
What does this MR do and why?
Describe in detail what your merge request does and why.
Removes a conditional that never triggers, and that references a constant that doesn't exist.
The constant used to exist in https://gitlab.com/gitlab-org/gitlab/-/blob/d96585f5739f4cb83fd00fa402192a15d6958881/app/models/global_milestone.rb#L7 but was missed when moving the code over to a new class. However it never raises an error because the conditional can never trigger as projects
is a required parameter, and is seemingly never called with nil
in the codebase. An empty array will still return the default values below anyway.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.