Update FeatureFlagUsage cop's exclude list
What does this MR do and why?
This MR moves MultiStore
into lib/gitlab/patch
to better enforce the use of feature-flags in patched code. Even though MultiStore
does not directly monkey-patch redis-rb
classes, it introduces a similar behaviour by "intercepting" redis-rb calls (typical redis commands).
This MR removes multi_store.rb
from the Cop/FeatureFlagUsage
's exclude list. We add the rubocop:disable
inline to more explicitly allow Feature flag usage. This reduces confusion as to why a single file is excluded.
Issue: #385971 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.