Skip to content

Add noteable commenters GraphQL field

Lee Tickett requested to merge gitlab-community/gitlab:add-noteable-commenters-field-retry into master

What does this MR do and why?

!105935 (merged) had to be reverted because of some test gaps causing a broken master. This MR re-introduces the changes with the test gaps plugged 🤞

We currently have to enumerate all notes on merge requests for reporting everyone who contributed (e.g. everyone who commented). This is hugely inefficient: gitlab-org/quality/toolbox!108 (merged)

This MR introduces a commenters field which simply returns the distinct list of note authors (pushing the processing to the server and hugely reducing the data we need to fetch).

Screenshots or screen recordings

image

image

How to set up and validate locally

    query {
      projects {
       nodes {
         fullPath
         issues {
          nodes {
            id
            iid
            commenters {
              nodes {
                username
                name
              }
            }
          }
        }
       }
     }
   }

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports