Skip to content

Draft: Add static mapping for graphQL types specs

David Dieulivol requested to merge ddieulivol-add_graphql_types_specs_in_detect_tests_job into master

From Draft to Ready

  • Update description with results from the latest pipeline (to see if the correct specs have been run in minimal jobs)
  • Drop commit 4eea7a69

What does this MR do and why?

Closes #386756 (closed)

Whenever we change a file in app/graphql/types or ee/app/graphql/types, we trigger all the specs in spec/graphql/types or ee/spec/graphql/types respectively.

Does it work?

  • Added a dummy change in app/graphql/types/notes/noteable_interface.rb and ee/app/graphql/types/epic_type.rb to test both mappings (see commit)
  • detect-tests job (https://gitlab.com/gitlab-org/gitlab/-/jobs/3531224867) contains spec/graphql/types and ee/spec/graphql/types. The first one is listed in both as Related RSpec tests/Related FOSS RSpec tests, whereas the second one is only listed in Related RSpec tests as one would expect.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Dieulivol

Merge request reports