Skip to content

Fix BgMigration/FeatureCategory cop violations on silenced bg migrations

Prabakaran Murugesan requested to merge 386739-fix-bg-migration-feature-category-cop-old-violations into master

What does this MR do and why?

!106147 (merged) introduced a cop to ensure the presence of feature-category attribute in BatchedMigrationJobs with a grace period and excluding existing jobs. This MR takes care of addressing those excluded files.

  • To Set feature_category as :database for all the existing background migrations
  • Update db review doc, to capture this step.
  • Remove the handled files from cop's excluded list.

How to set up and validate locally

> rubocop lib/gitlab/background_migration/*
> rubocop rubocop/cop/background_migration/feature_category.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #386739 (closed)

Edited by Prabakaran Murugesan

Merge request reports