Skip to content

Switched the Header component to use global GET_MODIFIER_KEY

Denys Mishunov requested to merge 385852-modifier-key-header into master

What does this MR do and why?

Refactors the Header component used for the toolbar buttons for the markdown fields (comments, descriptions, etc.) to use the global getModifierKey() instead of the local computations.

Screenshots or screen recordings

Before After
Screenshot_2023-01-05_at_09.27.25 Screenshot_2023-01-04_at_15.57.53
Screenshot_2023-01-05_at_09.27.30 Screenshot_2023-01-04_at_15.57.58
Screenshot_2023-01-05_at_09.27.34 Screenshot_2023-01-04_at_15.58.02
Screenshot_2023-01-05_at_09.27.38 Screenshot_2023-01-04_at_15.58.06

How to set up and validate locally

  1. Edit any Markdown file in a repo
  2. On the Web Editor's toolbar, hover over the buttons to makes sure the keystrokes in the tooltips are correct when it comes to the modifier key

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #385852 (closed)

Edited by Denys Mishunov

Merge request reports

Loading