Dont log empty search params
What does this MR do and why?
Recently, an MR added environments page search query to logs with a meta.environment.search
key. During maintainer code review a follow up was suggested.
Suggestion is, when the search query is empty, do not add meta.environment.search
instead of logging it with an empty value. This MR implements that suggestion.
How to set up and validate locally
- Click Deployments => Environments
- Check
log/development_json.log
. It should not have a log entry with keymeta.environment.search
- In the Environments page, search an environment with a query
- Check
log/development_json.log
again. It should have a log entry with keymeta.environment.search
and value being the query.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Halil Coban