Update net-ldap to v0.17.1
What does this MR do and why?
Refs #383556 (closed)
This version brings in required changes to get Ruby 3 support:
https://github.com/ruby-ldap/ruby-net-ldap/releases/tag/v0.17.1
From 0.17.1:
Fixed shebang of bash #385
Omit some tests for now until we update our CA cert #386
Add Ruby 3.0 support #388
Add TruffleRuby 21.0.0 to CI #389
Correct a typo in an error message #391
Enable bundler caching for travis #390
Fix circular require while loading lib/net/ldap/entry.rb and lib/net/ldap/dataset.rb #392
Handle nil value in GetbyteForSSLSocket::getbyte #306
From 0.17.0:
Added private recursive_delete as alternative to DELETE_TREE #268
Test suite updates #373 #376 #377
Use Base64.strict_encode64 and SSHA256 #303
Remove deprecated ConnectionRefusedError #366
Added method to get a duplicate of the internal Hash #286
Remove a circular require #380
Fix LdapServerAsnSyntax compile #379
Implement '==' operator for entries #381
Fix for undefined method for write exception #383
Diff: https://my.diffend.io/gems/net-ldap/0.16.3/0.17.1 (I think only page 1 contains meaningful change, the rest is test config and artifacts)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Set up LDAP for your local GDK instance: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/ldap.md#ldap
- Confirm that you can login via LDAP by visiting http://localhost:3000/users/sign_in and logging in as one of the LDAP users (
john
ormary
) - Confirm that you can set up LDAP group sync following the docs here. This will involve logging in as one of the LDAP users and then creating a GitLab group, then setting up LDAP member sync for that group.
- Confirm that syncing members for the group works. For example, if you set up a GitLab group to sync with the LDAP
group1
,john
andmary
should be added as members once sync completes.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #383556 (closed)
Edited by Jessie Young