Fix Elastic migration tests that dirty the state
What does this MR do and why?
This resolves the flakiness so that the example doesn't have to be retried in a new process, but strangely the example only passes after an in-process retry (with rspec-retry
), as can be seen at https://gitlab.com/gitlab-org/gitlab/-/jobs/3589555402#L839. Before the change, it would always fail: https://gitlab.com/gitlab-org/gitlab/-/jobs/3582322554.
I believe this is already an improvement, but it's still puzzling why the example only passes on retry.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Rémy Coutable