Skip to content

Refactor SAML debug form to remove bootstrap_form_for helper

Mike Greiling requested to merge mg-remove-bootstrap-form into master

What does this MR do and why?

Removes the use of bootstrap_form helper methods within the SAML debug form so that the gem can be removed prior to the Ruby 3 migration.

The removal of the bootstrap_form inline error helpers mean that the way SAML validation hints are rendered is slightly downgraded. They are no longer displayed next to the relevant field and are instead listed in an alert above the form. There is no downgrade in functionality, however, and I think this is a fair compromise to unblock the removal of this outdated gem.

If necessary, a follow-up issue can be created to improve the aesthetics of the SAML validation hints.

Screenshots or screen recordings

Valid SAML response:

Before: After:
before-good after-good

Invalid SAML response:

Before: After:
before-bad after-bad

How to set up and validate locally

  1. Set up SAML SSO in your GDK (guide here)
  2. Configure a group SAML integration
  3. Once you've validated that the test integration is working, click on the "Verify SAML Configuration" button
    • CleanShot_2023-01-27_at_13.15.50_2x
  4. Observe that the resulting SAML response debug page renders without error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Part of #359430 (closed)

Edited by Mike Greiling

Merge request reports

Loading