Stop using hideFlash
What does this MR do and why?
For vue_merge_request_widget
related files, we replace hideFlash
by
keeping track of created alerts and use their dismiss()
methods.
For the rest, we replaced hideFlash
by clicking on the close button in
the alerts (JavaScript) or flash (Rails) elements.
On a follow-up we will remove the hideFlash
code all together. We can't
do it now, because addDismissFlashClickListener
depends on it.
Screenshots or screen recordings
N/A
How to set up and validate locally
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Eduardo Sanz García