Update pipeline sec report when dismissing a finding via modal
requested to merge 386026-dismissing-vulnerability-via-modal-on-pipeline-page-don-t-update-until-the-page-is-refreshed into master
What does this MR do and why?
It fixes an issue in which the pipeline vulnerability report does not update after a finding gets dismissed via the modal and "hide dismissed" is active.
The cause for the issue was a change within the Vuex data responsible for handling filters.
Screenshots or screen recordings
| current | fixed |
|---|---|
| current | fixed |
How to set up and validate locally
Setup
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Go to the pipeline's security report tab
- Click on a finding and dismiss it from the modal
- If the "hide dismissed" toggle is enabled the dismissed finding should not be visible any more
- The toast message that pops up should allow you to undo the dismissal
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #386026 (closed)
Edited by David Pisek