Skip to content

Use button text to open Approvals dropdown list in E2E test

Jay McCure requested to merge jmc-fix-approvals-e2e-test into master

What does this MR do and why?

Resolves #387607 (closed) as test is failing after !108013 (merged) was merged

This MR updates the selector for the button to open the Users and Groups approvals dropdown list for a merge request.

The previous selector being used .dropdown was being clicked successfully but it is no longer opening the dropdown list as desired. This MR now uses the button text with click_button which does open the dropdown list. A data-qa-selector was not used as this is a common component from the gitlab-ui project.

How to set up and validate locally

GITLAB_QA_PASSWORD_1=XXX GITLAB_QA_PASSWORD_2=XXX bundle exec rspec qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports