Skip to content

Align listbox with current naming

Paulina Sedlak-Jakubowska requested to merge 373854-align-dropwdown-with-current-naming into master

What does this MR do and why?

I recently did a couple of dropdown migrations and got a comment about using GlListbox component (!107493 (comment 1233200340))

chore: update GlListbox to GlCollapsibleListbox to align with current naming (following WAI ARIA example). For more context check out the Epic and issue comment.

So here's a MR that changes GlListbox to GlCollapsibleListbox for recently created incident event tags.

Screenshots or screen recordings

No visual changes, it's just a name of a component and some variables names.

How to set up and validate locally

  1. Open the Rails Console in a terminal under the gitlab/ folder: rails c
  2. Run Feature.enable(:incident_event_tags) to enable to feature globally for your GitLab instance.
  3. Navigate to Monitor > Incidents page
  4. Create new or open an existing incident
  5. Navigate to Timeline tab of the incident
  6. Click "Add new timeline event" button at the bottom
  7. Choose a tag from dropdown to fill in the note with default content

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #373854 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports