Skip to content

E2E: Use Unique Parent Group for user_inherited_access_spec

What does this MR do and why?

Updates the group hierarchies in qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb and qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb to use a unique parent group rather than the sandbox group.

This is to help resolve flakiness experienced by these tests due to project authorization refresh delays.

More detailed explanations around why these changes are needed can be found here:

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Check out this branch locally and run from the qa directory: GITLAB_INITIAL_ROOT_PASSWORD=<gdk root password here> QA_GITLAB_URL=<gdk url here> bundle exec rspec qa/specs/features/api/1_manage/user_inherited_access_spec.rb (or, qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb)
  2. You can also add a binding.pry breakpoint within the test to verify the hierarchy should now be the following:

For when added to the parent group test cases

gitlab-qa-sandbox-group-*
  parent-group-to-test-user-access-*
    sub-group-to-test-user-access-*
      sub-group-project-to-test-user-access

For when added to the subgroup test cases

gitlab-qa-sandbox-group-*
  parent-group-to-test-user-access-*
    parent-group-project-to-test-user-access
    sub-group-to-test-user-access-*

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading