Skip to content

Mention possible consequence of diverging values

Manuel Grabowski requested to merge docs/mg-sidekiqpileup-20230118 into master

What does this MR do?

Adds a more concrete example of what can happen when not following the advice – only saying "more predictable results" was very abstract. Also clarifies not defining min_concurrency.

We ran into this while working on 🎫 #358871 (internal). The exact circumstances were a bit more specific:

  • min_concurrency not defined at all, another detail this MR aims to explain better
  • routing_rules set up in a certain (but not uncommon) way

Considering this entire topic is already deprecated (as far as I understood things), this feels like a boring solution that improves the status quo – while we could add even more details based on the case above, it would further complicate an already fairly complex section.

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Manuel Grabowski

Merge request reports

Loading