Skip to content

Fix error showing while loading finding on graphql modal

What does this MR do and why?

Makes sure that the error message on the graphql finding modal does not show while we fetch.

Screenshots or screen recordings

Screenshot_2023-01-18_at_8.07.00_pm

How to set up and validate locally

Setup

  1. Have the related FF enabled: echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c
  2. You'll need an EE License
  3. You'll need to have runners enabled (See $2408961 for setting up a runner)
  4. Import https://gitlab.com/gitlab-examples/security/security-reports
  5. Run a pipeline on master

Validation

  1. Go to the pipeline's security report tab
  2. Throttle your browser's internet speed via the developer tools
  3. Click on a finding
  4. Verify that the error is not showing while loading

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Pisek

Merge request reports

Loading