Skip to content

Move learn gitlab code to ee

Doug Stull requested to merge 387662-move-learn-gitlab-to-ee into master

What does this MR do and why?

What

  • No behavior changes outside of moving code from a foss/ee split to only ee
  • Moves learn gitlab code to ee since it can only ever be created in ee.
  • Resolves minor rubocop issues.
  • Moves invite_for_help_continuous_onboarding experiment to ee due to invocation from learn gitlab. Current set to 50% enabled in production.
  • Moves video_tutorials_continuous_onboarding experiment to ee due to invocation from learn gitlab. Current set to 50% enabled in production.

note for frontend - there is one remaining learn gitlab item in the items around isOnLearnGitlab that we can handle in a follow up as mentioned in the issue.

feature specs in ee/spec/features/registrations/saas cover the end to end nature of this change.

  • ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb would be the easiest thing to follow if looking to reproduce the steps/verification manually. I didn't include specific verification instructions here since there are no visual changes and the feature specs like this one covers it fully. (I did validate this manually myself following this spec on gdk)

Why

Currently learn gitlab code is mixed between foss and ee. However, it is only ever created from ee.

Only place learn gitlab is created is here which is in ee and invoked from the controller in ee. There is a separate discussion for the future about if groups/projects creation during registration should/could move to foss, but for now this is the boring solution and fixes the current state of code for learn gitlab.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #387662 (closed)

Edited by Doug Stull

Merge request reports