Add non-nested generic report types to GraphQL finding modal
What does this MR do and why?
Adds the remaining (non-nested) generic report types to the new, GraphQL version of the finding modal:
- ModuleLocation
- Commit
- Text
- Markdown
- Boolean
- Int
It also includes a small refactor that moves the GraphQL-type -> component map out of a shared constants file.
Screenshots or screen recordings
How to set up and validate locally
Setup
- Have the related FF enabled:
echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Go to the pipeline's security report tab
- Click on the finding with the title "X-Frame-Options Header Not Set"
- Verify that all the fields render as-expected
Note: The current test data only renders a subset of types, but once the list
and table
types are rendered, we should have a full picture.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by David Pisek