Skip to content

Don't create an ee/ folder when not in EE context

Rémy Coutable requested to merge fix-db-rake-which-creates-ee-folder into master

What does this MR do and why?

The gitlab:db:dictionary:generate task creates the ee/db/docs folder without checking if we're in the EE context or not! 👮🏼 This ends up breaking test jobs in the FOSS context (e.g. gitlab-org/quality/engineering-productivity/master-broken-incidents#678 (closed) but this also happens in MRs: https://gitlab.com/gitlab-org/gitlab/-/jobs/3657174350).

This was introduced by !108252 (diffs, comment 1252227471) (tests for the task were added by !109208 (merged) but it seems they're not ensuring that the EE folder isn't created in the FOSS context).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rémy Coutable

Merge request reports