Skip to content

Let users add more deploy rules to an environment

Andrew Fontaine requested to merge afontaine/edit-protected-environments-deployers--add into master

What does this MR do and why?

Users might need to change who is allowed to deploy to an environment, and so need the ability to add rules.

The UX is a little wonky due to AccessLevelDropdown being more of an all in one app than a reusable component, but the work to correct that will be in a follow up.

Screenshots or screen recordings

image

image

How to set up and validate locally

  1. Enable the feature flag:
Feature.enable(:multiple_environment_approval_rules_fe)
  1. Navigate to a project's environments page Deployments > Environments
  2. Add an environment
  3. Navigate to the CI/CD settings page Settings > CI/CD
  4. Protect the environment
  5. View the protected environment
  6. add a deployer rule

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

For #378446 (closed), part of !109157 (closed)

Merge request reports