Skip to content

Fix Deployments::Hooksworker params for Sidekiq

Halil Coban requested to merge cleanup-improve_deployment_hooksworker_serialization into master

What does this MR do and why?

Cleans up improve_deployment_hooksworker_serialization feature flag.

When feature flag was enabled, the job arguments to Deployments::Hooksworker is correctly serialized (does not pass hash keys or time objects). The feature flag is enabled to 100% users since Jan 25th and I can confirm that the following Sidekiq client warning does not appear in logs anymore.

Job arguments to Deployments::HooksWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Create a deployment
  2. Check logs/sidekiq_client.log
  3. You should not see a warning related to job argument serialization for Deployments::Hooksworker

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports