Move Learn Gitlab JS to ee
requested to merge 387662-refactor-welcome-controller-code-to-reduce-duplicating-and-increase-clarity-lg-js into master
What does this MR do and why?
Learn GitLab is an ee
only concern. Let's move as much as we can that references it to ee
.
Remove references to learn gitlab from foss
invite members modal and instead only define it in the ee
version.
How to validate locally
note basically trying to emulate feature spec steps in ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb
- Setup to simulate SaaS and restart GDK
- Enable the
invite_for_help_continuous_onboarding
feature flag in rails console withFeature.enable(:invite_for_help_continuous_onboarding)
- Register as a new user.
- Confirm email by finding the confirmation path from last User created in
rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
- Visit the path from the previous step.
- You should be on the sign in page, log back in.
- Select any 'role' and 'Just me' in the welcome form after sign up step.
- Choose 'Create a new project'
- Click 'Continue'
- Fill out fields to create a group and project on the next page.
- Click 'Create project'
- Verify you get to the onboarding and page refreshes to provide a "Ok, let's go" button.
- Click on "Ok, let's go" and verify you are dropped into the learn gitlab project and the celebrate modal pops up with confetti
- Close that modal.
- Click on the
Invite your colleagues
link and observe the modal.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #387662 (closed)
Edited by Doug Stull