Skip to content

Show version check in new Help menu

Thomas Hutterer requested to merge super_sidebar_version_check into master

What does this MR do and why?

Implements the missing version check in the new Help menu for the new navigation. See #385748 (comment 1256097162)

Part of #385748 (closed).

Screenshots or screen recordings

up to date old version
image image

How to set up and validate locally

Before you begin:

  • Make sure your local GDK does not run in SaaS mode.
  • Enable the new navigation feature flag: Feature.enable(:super_sidebar_nav)
  • In the web UI, click your user avatar and then toggle New navigation.
  • You should now see the "super sidebar" navigation. The Help menu is on the bottom-left.

First review the new version check section:

  • Open the Help menu. It should now show a Your GitLab version section on the top.
  • It should say that you are on the latest version.
  • Clicking it brings you to the upgrade guide.

Now let's simulate an older version:

  • Run gdk stop.
  • Edit the VERSION file in your local gitlab root folder and change the version number to something lower, like 15.7.0.
  • gdk start, open a gdk rails console and execute VersionCheck.new.clear_reactive_cache!. This is required as the response from gitlab.com is cached for 12 hours otherwise.
  • Reload in your browser. The first time, the cache was empty and the version check badge won't show.
  • Wait a moment and reload again. The version check section should now show its colored badge, asking you to upgrade.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports