Skip to content

Retry key parts of the review-deploy job

David Dieulivol requested to merge ddieulivol-retry_review_deploy_steps into master

What does this MR do and why?

Follow-up of https://gitlab.slack.com/archives/C011EM0RB71/p1675182022300859?thread_ts=1675180944.312629&cid=C011EM0RB71 (internal link):

We should retry the namespace creation (and the actions afterwards, labeling namespacing, creating secrets, …). If any one of them fail, the deploy will eventually fail. I’ll take care of it tomorrow.

This MR should prevent errors like the one in https://gitlab.com/gitlab-org/gitlab/-/jobs/3688996265 to happen again (unless the error we encounter is more persistent than the time it takes to do the retry. It would still be time to change to exponential retries).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Dieulivol

Merge request reports