Fix undo dismiss should clear comments
What does this MR do and why?
When a finding is reverted back to detected, the dismissal_feedback
property should be nullified.
Screenshots or screen recordings
How to set up and validate locally
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Enable
:refactor_security_extension
to turn this feature on.
echo "Feature.enable(:refactor_security_extension)" | rails c
Steps:
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Create a new MR by modifying a file
- Expand the Security Reports Widget from the UI
- Dismiss a finding
- Check that there is a
Dismissed
comment - Click again on the same finding to
Undo Dismiss
- Re-open the modal
- The
Dismissed
comment should not be visible anymore
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #390207 (closed)