Skip to content

Add dismissal to graphql sec-finding modal

David Pisek requested to merge 390214-add-dismiss-functionality into master

What does this MR do and why?

It adds the dismissal functionality to the GraphQL security finding modal.

Note: Currently the dismissal state is only updated within the modal, not on the report. The modal emits an event after the finding gets dismissed, but this hasn't been wired up with the report yet.

Screenshots or screen recordings

Screen_Recording_2023-02-02_at_9.34.18_am

How to set up and validate locally

Setup

  1. Have the related FF enabled: echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c
  2. You'll need an EE License
  3. You'll need to have runners enabled (See $2408961 for setting up a runner)
  4. Import https://gitlab.com/gitlab-examples/security/security-reports
  5. Run a pipeline on master

Validation

  1. Go to the pipeline's security report tab
  2. Click on a finding to open the modal
  3. Verify that the findings status is "Detected"
  4. Click on "Dismiss"
  5. The modal should close and when the same finding is opened again, it should be flagged as "Dismissed"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #390214 (closed)

Edited by David Pisek

Merge request reports