Skip to content

Use environment variables to replace registry host and group

Zehua Zhang requested to merge gitlab-jh/jh-team/gitlab:use-env-variables-to-replace-registry-host-and-group into master

What does this MR do and why?

These changes 0b95328c caused the pipeline to fail on the JH side.

In the discussions of this issue gitlab-jh/gitlab#347, We decided to sync the registry.gitlab.com image to JH's own address registry.gitlab.cn to solve the problem of pulling the images, And use ${REGISTRY_HOST} and ${REGISTRY_GROUP} to represent the registry's address and organization. For example: https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/ci/global.gitlab-ci.yml#L354

So the top change caused the JH pipeline to fail because we couldn't pull the image registry.gitlab.com/gitlab-org/gitlab-build-images:zoekt-ci-image-1.0. So I mentioned the MR To replace registry.gitlab.com with ${REGISTRY_HOST}, Replace gitlab-org with ${REGISTRY_GROUP}.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports