Skip to content

Move review-stop to the same level as start-review-app-pipeline

Lin Jen-Shin requested to merge avoid-deadlock-for-review-stop into master

What does this MR do and why?

This is a simplified version of !103540 (closed)

  • Construction (start-review-app-pipeline) and destruction (review-stop and review-cleanup) should be on the same level
  • For the sake of allowing on_stop still works on the child pipeline, we still keep review-stop in the child pipeline, but it'll just play the one in the parent pipeline. This will not deadlock because it's just scheduling the parent one to run, and it'll not lock on the resource_group.

See #381415 (comment 1172982554)

Example jobs

Edited by Lin Jen-Shin

Merge request reports

Loading