Move learn gitlab from index to show for more resourceful routing
What does this MR do and why?
What
- Moves learn gitlab index action to a show action. No path changes.
- Other minor refactoring and cleanup
Why
- Makes this a more resourceful route based off of
project_id
and preps for move of onboarding to this controller in !109243 (merged)
Screenshots or screen recordings
How to set up and validate locally
note basically trying to emulate feature spec steps in ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb
- Setup to simulate SaaS and restart GDK
- Register as a new user.
- Confirm email by finding the confirmation path from last User created in
rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
- Visit the path from the previous step.
- You should be on the sign in page, log back in.
- Select any 'role' and 'Just me' in the welcome form after sign up step.
- Choose 'Create a new project'
- Click 'Continue'
- Fill out fields to create a group and project on the next page.
- Click 'Create project'
- Verify you get to the onboarding and page refreshes to provide a "Ok, let's go" button.
- Click on "Ok, let's go" and verify you are dropped into the learn gitlab project and the celebrate modal pops up with confetti
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #387662 (closed)
Edited by Doug Stull