Skip to content

Refactored method of updating Ukraine country name

What does this MR do and why?

What

This is a solution to a follow-up issue #391496, related to work done here !111587 (merged).

This MR refactors the method of overriding the country name for Ukraine. With this change, we only override the name, rather than hardcoding all attributes.

Why

The goal is to minimise the risk of the country data getting out of sync. This change also adds consistency to the countries.rb initialiser, by preforming the override in the same way it is done for the country Taiwan.

No tests need to be added or changed. There should be no visible change to the end user.

Screenshots or screen recordings

No visible change

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Setup your local GDK to simulate a SAAS instance.
  2. Navigate to one of the following URLs:
    • http://127.0.0.1:3000/users/sign_up/company/new
    • http://127.0.0.1:3000/-/trials/new
  3. Confirm the country name for Ukraine is unchanged and reads: Ukraine (except the Crimea, Donetsk, and Luhansk regions)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #391496

Merge request reports

Loading