Add dismiss-with-comment to GraphQL finding modal
What does this MR do and why?
It adds the capability to dismiss a given finding with a comment to the new, GraphQL version of the finding modal.
Screenshots or screen recordings
Screen_Recording_2023-02-14_at_2.45.05_pm
How to set up and validate locally
Setup
- Have the related FF enabled:
echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Go to the pipeline's security report tab
- Click on a finding that is not dismissed
- Hover over the "Dismiss with comment" button and verify that the tooltip is rendering
- Click on the "Dismiss with comment" button and verify that the comment section, including a textarea, opens
- Enter a comment, dismiss and verify that the GraphQL payload includes a
comment
field within the input payload
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #390216 (closed)
Edited by David Pisek