Skip to content

Add same SSH ports check for geo::check rake task

Mariia Solodovnik requested to merge 390383-add-geo-ssh-port-limitation-to-geo-check-rake-task into master

What does this MR do and why?

Add a new check to the gitlab:geo:check rake task to ensure SSH ports validation.

SSH ports should be similar to avoid the bug with exposing external_url of the primary node in the clone dialog. #339262 proposes to remove this limitation

Screenshots or screen recordings

  1. When ports are different image
  2. When ports are the same image

How to set up and validate locally

  1. If you're using the default setup, then your geo secondary site has the default SSH port 2222. Specify different SSH port in the primary site's gdk.yml file:
sshd:
  enabled: true
  listen_port: 2223
  1. Run bin/rake gitlab:geo:check command on the secondary site
  2. See the results of the check GitLab Geo secondary SSH port is the same as the primary ...

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #390383 (closed)

Edited by Mariia Solodovnik

Merge request reports